fix regression while adding the health diagnosis on failure (#628)

health["diagnosis"] is expected to return a string, but due to incorrect replacement, it started returning a tuple, which breaks other services that depend on this value. Co-authored-by: Matheus Svolenski <[email protected]>
mendix · May 2, 2023 · 9a6c7cd · 9a6c7cd
1 parent 7e77135
commit 9a6c7cd
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/buildpack/telemetry/metrics.py b/buildpack/telemetry/metrics.py
@@ -352,8 +352,8 @@ def _inject_health(self, stats):
                 else:
                     health["health"] = translation["critical"]
                     health["diagnosis"] = (
-                        "Health check failed unexpectedly: %s",
-                        health_response.get_error(),
+                        "Health check failed unexpectedly: "
+                        f"{health_response.get_error()}"
                     )
             else:
                 feedback = health_response.get_feedback()
@@ -365,7 +365,7 @@ def _inject_health(self, stats):
         except Exception as exc:
             logging.warning("Metrics: Failed to get health status %s", str(exc))
             health["health"] = translation["critical"]
-            health["diagnosis"] = "Health check failed unexpectedly: %s", exc
+            health["diagnosis"] = f"Health check failed unexpectedly: {exc}"
         return stats
 
     @staticmethod