-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tree scale bar on Sidebar #2278
Conversation
I'm looking for tools that produce the same scale bar results for the same newick tree.
Here is my test Tree from our phylogenomic workflow: (Prevotella_intermedia_19600:0.05650,Prevotella_denticola_19594:0.03030,(Prevotella_dentalis_19591:0.06281,(((Salmonella_enterica_21806:0.0,Salmonella_enterica_22289:0.0,Salmonella_enterica_22047:0.0):0.00138,(Escherichia_albertii_6917:0.00229,(Escherichia_coli_6920:0.0,Escherichia_coli_9038:0.0):0.00077)0.874:0.00864)1.000:0.87683,((Bacteroides_fragilis_2347:0.0,Bacteroides_fragilis_2346:0.0):0.00055,Bacteroides_fragilis_2334:0.00067)1.000:0.09888)0.996:0.06766)0.993:0.02687);
|
This is excellent work, Mete! Thanks for evaluating other tools, as well. One quick question. Does this bar here will change if people zoom-in or zoom-out? If not, we can think of a way to ensure its relevance. For instance, when people click Draw it woudl appear, but if they zoom in or zoom out it would disappear and the div would be replaced with "Click Draw to See the Tree Scale" or something (removing the need to adjust it in real time to different levels of zoom behavior). |
I didn't add any interactive behavior to avoid breaking the zoom functionality of our chart, but your idea sounds great! |
Do Not Merge
I was using same approach with Ete3 but I realize they have some problem with their calculation.
Due to that, I open a issue to ETE to understand what is wrong with that calculation:
etetoolkit/ete#753