Simplify test workflow file #166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ddundo
added
the
testing
4 tasks
ddundo
added a commit
to mesh-adaptation/docs
that referenced
this pull request
Dec 14, 2024
Related PRs: - [x] Animate: mesh-adaptation/animate#166 - [x] Goalie: mesh-adaptation/goalie#257 - [x] Movement: mesh-adaptation/movement#137 - [x] UM2N: mesh-adaptation/UM2N#64 --- This PR simplifies the `reusable_test_suite.yml` workflow: - Not using the `changed-files` action; instead, the triggers are to be set in the Animate/Goalie/Movement/UM2N workflows using the `paths` syntax - The `build` directory doesn't exist so `rm -rf build` does nothing (I guess this was a copy-paste error from the docs build) - Not unnecessarily installing python with `actions/setup-python@v2` - Not uninstalling and installing Animate/Goalie/Movement/UM2N again since `actions/checkout@v4` fetches the repository at the state of the commit that triggered the workflow, so it is always up to date - In the "Run tests" step we have so far passed commands here from other repos, where I think `export GITHUB_ACTIONS_TEST_RUN=1` is unnecessary (not used anywhere?) And one addition: - Print missing statements in coverage (i.e., added the `-m` flag in `python -m coverage report -m`)
jwallwork23
approved these changes
Dec 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to mesh-adaptation/docs#90