Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement MeshTanglingChecker in 1D and 3D #142

Merged
merged 13 commits into from
Jan 13, 2025
Merged

Implement MeshTanglingChecker in 1D and 3D #142

merged 13 commits into from
Jan 13, 2025

Conversation

jwallwork23
Copy link
Member

Closes #141.

This PR overhauls the tangling checking functionality:

  • Simplify the implementation to just check for changes in the sign of the determinant of the Jacobian.
  • This extends automatically to the 1D and 3D cases, as well as the already covered 2D case.
  • Extend the test suite to cover other dimensions and cases.

@jwallwork23 jwallwork23 added the enhancement New feature or request label Dec 28, 2024
@jwallwork23 jwallwork23 self-assigned this Dec 28, 2024
ddundo
ddundo approved these changes Jan 10, 2025
View reviewed changes
Copy link
Member

@ddundo ddundo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Just minor comments which you might want to ignore :)

movement/tangling.py Outdated Show resolved Hide resolved
movement/tangling.py Outdated Show resolved Hide resolved
movement/tangling.py Outdated Show resolved Hide resolved
movement/tangling.py Outdated Show resolved Hide resolved
movement/tangling.py Outdated Show resolved Hide resolved
ddundo
ddundo reviewed Jan 13, 2025
View reviewed changes
movement/tangling.py Outdated Show resolved Hide resolved
@jwallwork23 jwallwork23 merged commit 5281eb5 into main Jan 13, 2025
1 check passed
@jwallwork23 jwallwork23 deleted the 141_tangling-extension branch January 13, 2025 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ddundo ddundo ddundo approved these changes

@stephankramer stephankramer Awaiting requested review from stephankramer

Assignees

@jwallwork23 jwallwork23

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement MeshTanglingChecker in 1D and 3D
2 participants
@jwallwork23 @ddundo