Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix PETSc errors in CI #152

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Fix PETSc errors in CI #152

wants to merge 3 commits into from

Conversation

jwallwork23
Copy link
Member

@jwallwork23 jwallwork23 commented Jan 21, 2025 •
edited
Loading

Closes #151.

This PR addresses two issues that cropped up with recent Firedrake updates:

  • Assembling a 1-form to a tensor now requires the tensor to be represented as a Cofunction.
  • The Quasi-Newton solver no longer works in 1D. Looking more closely, I'm surprised it ever did. It uses a vector space basis that accesses sub(1), which doesn't exist in 1D. I think it's best to just drop support for the QN approach in 1D, as done here.

@jwallwork23 jwallwork23 added the bug Something isn't working label Jan 21, 2025
@jwallwork23 jwallwork23 self-assigned this Jan 21, 2025
@jwallwork23 jwallwork23 force-pushed the 151_cofunction-fix-ci branch from 943c8d9 to 07542b0 Compare January 30, 2025 08:50
@jwallwork23 jwallwork23 marked this pull request as ready for review January 30, 2025 09:58
ddundo
ddundo approved these changes Feb 2, 2025
View reviewed changes
Copy link
Member

@ddundo ddundo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not familiar with this so I'm approving without checking if you just want to merge :)

@ddundo
Copy link
Member

ddundo commented Feb 2, 2025 •
edited
Loading

Btw it would be nice to not have an Animate-dependent solution, but I don't have an alternative suggestion other than just copying function2cofunction to Movement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ddundo ddundo ddundo approved these changes

@stephankramer stephankramer Awaiting requested review from stephankramer

Assignees

@jwallwork23 jwallwork23

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Lots of PETSc errors in CI
2 participants
@jwallwork23 @ddundo