Copy mesh upon creating Mover #48
Conversation
| # Continue with a new Mover | ||
| mover = MongeAmpereMover( | ||
| mesh, ring_monitor, method=method, rtol=rtol, phi_init=phi, sigma_init=sigma | ||
| ) |
There was a problem hiding this comment.
It doesn't really make sense to 'continue' the mesh movement by creating a new Mover with the computational mesh being the adapted mesh from an earlier Mover. They have different baselines.
There was a problem hiding this comment.
Ah yes, I was wondering about that/discussing with Matt: in our current implementation we are always working with a uniform mesh as the baseline right? And so the monitor we provide is specifying the required variation in the output physical mesh regardless of the previous state of the mesh (when calling the mover multiple times). We could also imagine a different approach where the monitor expresses the variation with respect to the previous mesh, where if the mesh is already optimal the monitor would be constant.
Closes #45.
Copy the mesh that gets passed to a Mover so that the original remains unmodified.