Fix gradient in turbine example #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acse-ej321
approved these changes
Jan 9, 2025
demos/turbine/setup.py
Outdated
| # NOTE: negative because we want maximum | ||
|
|
||
| # Add a regularisation term for constraining the control | ||
| area = assemble(Constant(1.0) * ufl.dx(domain=mesh)) | ||
| alpha = 1.0 / area | ||
| alpha = Constant(1.0 / area) |
There was a problem hiding this comment.
You have changed all the other Constant terms to be in terms of R space except here and line 157. Just flagging with a comment in case this was unintentional.
There was a problem hiding this comment.
Thanks for pointing this out. I've updated it to use Thetis' new domain_constant in df4692e.
|
Okay it seems to be working now! The key fix was for the regularisation term - the sign was wrong and y2 and y3 were the wrong way round. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #37.
While #36 re-enables the turbines in the turbine example, there's still something not right because the optimisation progress is non-monotonic and the control turbine area occasionally goes to zero.
I added a Taylor test and found that the gradient of the QoI wasn't being computed correctly with the existing setup. I tracked the problem down to the$\mathbb{P}1_{DG}$ space, the Taylor test passed.
turbine_densityexpression, which includes several terms. By projecting this expression intoIn addition, this PR overhauls the plotting functionality.