compilers/clike: Speedup cross_compute_int

[sp1ritCS]

Expand the expression passed into cross_compute_int using the preprocessor first and then try to evaluate the expanded expression using the host machine compiler and test if the result is valid.

See #13910 for previous discussion

[nirbheek]

LGTM now, can we rebase and check CI?

[nirbheek]

Also could you please verify that this codepath is indeed tested on the CI in one of the cross-compile jobs? We also need to ensure that the old codepath is hit in one of the other jobs.

[sp1ritCS]

LGTM now, can we rebase and check CI?

Given the CI failures, this isn't ready to merge yet. Methinks I'll need to catch the exception thrown by get_define in cross_compute_int

[sp1ritCS]

Also could you please verify that this codepath is indeed tested on the CI in one of the cross-compile jobs? We also need to ensure that the old codepath is hit in one of the other jobs.

that'd mean common/134 compute int will have to be ran with a cross file without exe_wrapper. How would I do that? Both branches should be hit (sizeof(int) won't work with get_define).

[nirbheek]

You want to add such a test to unittests/linuxcrosstests.py that will let you customize it the way you want.

[nirbheek]

LGTM, will merge on Friday if there are no objections.