Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Bump traefik to 34.1.0 #3018

Merged
merged 8 commits into from
Jan 20, 2025

Conversation

mmatur
Copy link
Contributor

@mmatur mmatur commented Jan 15, 2025

Upgrades the following apps to use version 34.1.0 of chart traefik:

  • traefik from version 33.2.1 to 34.1.0
    • traefik version v3.3.2
    • remove rewrite body plugin to use the new option --api.basePath
    • use extraObjects instead of an initContainer

@mhrabovcin mhrabovcin added the ok-to-test Signals mergebot that CI checks are ready to be kicked off label Jan 16, 2025
@mhrabovcin mhrabovcin closed this Jan 16, 2025
@mhrabovcin mhrabovcin reopened this Jan 16, 2025
@coveralls
Copy link

coveralls commented Jan 16, 2025

Pull Request Test Coverage Report for Build 12842773293

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 51.703%

Totals Coverage Status
Change from base Build 12817743876: 0.0%
Covered Lines: 167
Relevant Lines: 323

💛 - Coveralls

@some-things
Copy link

Thank you @mmatur!

@mmatur mmatur requested a review from mhrabovcin January 17, 2025 06:12
@mhrabovcin mhrabovcin changed the base branch from main to mmatur/feat/traefik January 20, 2025 15:20
@mhrabovcin mhrabovcin merged commit b5a30df into mesosphere:mmatur/feat/traefik Jan 20, 2025
16 of 21 checks passed
mhrabovcin added a commit that referenced this pull request Jan 23, 2025
* feat: Bump traefik to 34.1.0 (#3018)

* feat: traefik v3.3.2 + helm 34.1.0

* fix for review

* feat: add support for GatewayAPI

* fix for review

* feat: upgrade grafana dashboard

* fix for review

* fix gateway api

* fix traefik dashboard ingressroute

* fix: traefik mw test assertion

* fix: pre-commit cm

* fix: adjust dashboard assertion

* fix: app test dashboard

* fix: add traefik port override

* fix: disable stags

* fix: traefik api assertions

* fix: upgrade tests asserts

* fix: panic

* fix: wait assertion

* fix: don't create default gateway

* fix: ingress status

Co-authored-by: Michael <[email protected]>

* fix: remove unused code

---------

Co-authored-by: Michael <[email protected]>
@@ -239,7 +239,7 @@ data:
kubernetes.io/ingress.class: kommander-traefik
ingress.kubernetes.io/auth-response-headers: X-Forwarded-User
traefik.ingress.kubernetes.io/router.tls: "true"
traefik.ingress.kubernetes.io/router.middlewares: "${releaseNamespace}-stripprefixes@kubernetescrd,${releaseNamespace}-forwardauth@kubernetescrd"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mhrabovcin why did we drop this here ? I tried accessing UI but couldn't do that so adding this back via #3068

lmk if i am missing sth here and if there is a better approach.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ok-to-test Signals mergebot that CI checks are ready to be kicked off
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants