Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cosi): bump cosi sidecar to v0.2.1 #3160

Merged
merged 2 commits into from
Feb 14, 2025
Merged

Conversation

takirala
Copy link
Contributor

@takirala takirala commented Feb 14, 2025

What problem does this PR solve?:

Fresh release - https://github.com/kubernetes-sigs/container-object-storage-interface/releases/tag/v0.2.1

Bumps cosi sidecar image to latest version (moves off of the deprecated gcr.io container registry). I made sure the new image does not add any new vulns:
Screenshot 2025-02-13 at 9 17 17 PM

Which issue(s) does this PR fix?:

Fixes https://jira.nutanix.com/browse/NCN-105729
Partially addresses https://jira.nutanix.com/browse/NCN-105713

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


Checklist

  • If the PR adds a version bump, ensure there is no breaking change in Licensing model (or NA).
  • If a chart is changed or app configuration is significantly changed, the chart version is correctly incremented (so that apps are not automatically upgraded from a previous version of DKP).

Signed-off-by: Tarun Gupta Akirala <[email protected]>
@github-actions github-actions bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. services/rook-ceph-cluster services/cosi-driver-nutanix and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 14, 2025
@mesosphere-ci mesosphere-ci added ok-to-test Signals mergebot that CI checks are ready to be kicked off do-not-merge/testing Do not merge because there is still on-going testing open-kommander-pr Automatically triggers the creation of a PR in Kommander repo update-licenses signals mergebot to update licenses.d2iq.yaml labels Feb 14, 2025
@takirala takirala added needs-backport Needs to be backported to a release branch backport-to-release-2.14 labels Feb 14, 2025
Copy link
Contributor

✅ Created Kommander branch to test kommander-applications changes: https://github.com/mesosphere/kommander/tree/kapps/main/tga/bump-cosi-sidecar

@coveralls
Copy link

coveralls commented Feb 14, 2025

Pull Request Test Coverage Report for Build 13336180739

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 51.703%

Totals Coverage Status
Change from base Build 13321011158: 0.0%
Covered Lines: 167
Relevant Lines: 323

💛 - Coveralls

@takirala
Copy link
Contributor Author

Upon validating the image, it looks like the ceph cosi driver has some compatibility issues with the recent version of sidecar image. Holding this off until i can test more.

@takirala takirala self-assigned this Feb 14, 2025
@takirala takirala marked this pull request as draft February 14, 2025 06:38
Signed-off-by: Tarun Gupta Akirala <[email protected]>
@github-actions github-actions bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Feb 14, 2025
@takirala takirala marked this pull request as ready for review February 14, 2025 19:38
@takirala
Copy link
Contributor Author

Published a new image on ghcr.io/mesophere mesosphere/dkp-container-images#16 and added it here. Tested manually to make sure it works.

@takirala takirala removed the do-not-merge/testing Do not merge because there is still on-going testing label Feb 14, 2025
@takirala takirala merged commit 649a8f2 into main Feb 14, 2025
31 checks passed
@takirala takirala deleted the tga/bump-cosi-sidecar branch February 14, 2025 19:49
mesosphere-ci pushed a commit that referenced this pull request Feb 14, 2025
* feat(cosi): bump cosi sidecar to v0.2.1

* chore: use old image for ceph sidecar

Signed-off-by: Tarun Gupta Akirala <[email protected]>
(cherry picked from commit 649a8f2)
@mesosphere-ci
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
release-2.14

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

takirala added a commit that referenced this pull request Feb 14, 2025
* feat(cosi): bump cosi sidecar to v0.2.1

* chore: use old image for ceph sidecar

Signed-off-by: Tarun Gupta Akirala <[email protected]>
(cherry picked from commit 649a8f2)

Co-authored-by: Tarun Gupta Akirala <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport backport-to-release-2.14 needs-backport Needs to be backported to a release branch ok-to-test Signals mergebot that CI checks are ready to be kicked off open-kommander-pr Automatically triggers the creation of a PR in Kommander repo services/cosi-driver-nutanix services/rook-ceph-cluster size/S Denotes a PR that changes 10-29 lines, ignoring generated files. update-licenses signals mergebot to update licenses.d2iq.yaml
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants