Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

llama stack build and llama stack run are not symmetric for --image-name argument when venv is used #1131

Open
2 tasks
booxter opened this issue Feb 17, 2025 · 3 comments · May be fixed by #1226
Open
2 tasks
Labels
bug Something isn't working

Comments

@booxter
Copy link
Contributor

booxter commented Feb 17, 2025

System Info

.

Information

  • The official example scripts
  • My own modified scripts

🐛 Describe the bug

When building and running with venv, I have to pass different --image-name. For build, it's always prepended with llamastack- prefix. For run, it's not. I think both commands should behave the same way, otherwise it's confusing.

$ llama stack build --template experimental-post-training --image-type venv --image-name train
$ llama stack run --image-type venv ~/.llama/distributions/experimental-post-training/experimental-post-training-run.yaml --image-name llamastack-train

Error logs

.

Expected behavior

Both commands should use the same --image-name format.

@booxter booxter added the bug Something isn't working label Feb 17, 2025
@booxter
Copy link
Contributor Author

booxter commented Feb 18, 2025

@cdoern FYI (Though not sure if this is specific to venv.)

@cdoern
Copy link
Contributor

cdoern commented Feb 18, 2025

@booxter I will take a look at this 🙏

@JamesKunstle
Copy link

JamesKunstle commented Feb 20, 2025

I just experienced the same thing, which was kinda confusing.

Steps:

  1. python3.11 -m venv venv
  2. source venv/bin/activate
  3. pip3 install ./llama-stack
  4. pip3 install ./llama-stack-client-python
  5. llama stack build --template ollama --image-type venv --> creates llamastack-None environment

The venv that's created should be named exactly what the user puts in --image-name during the build phase, and something more verbose, like f"llamastack-{template-name}-{conda | venv | image}" by default if they put nothing.

@cdoern cdoern linked a pull request Feb 24, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants