fix: image_name defaults to none #1226
Open
+4
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdoern
requested review from
ashwinb,
yanxi0830,
hardikjshah,
dltn,
raghotham,
dineshyv,
vladimirivic,
sixianyi0721,
ehhuang and
terrytangyuan
as code owners
facebook-github-bot
added
the
CLA Signed
leseb
reviewed
Feb 24, 2025
llama_stack/cli/stack/_build.py
Outdated
| if not image_name: | ||
| image_name = args.image_type | ||
| print( | ||
| f"No image name provided and could not detect one from environment. Using image_name: llamastack-{image_name}" |
There was a problem hiding this comment.
The log message and the code behave differently - while the code sets args.image_type to image_name, the log message includes a “llamastack-” prefix. Isn’t that a bit confusing?
There was a problem hiding this comment.
True, I was doing this because it seems in the interactive mode a default of llamastack-name is used. I will switch this to be image_name = f"llamastack-{args.image_type}" for continuity
since `--image-name` has a default of None, often a user can get `llamastack-None` when using environments like venv and container. currently, the image_name is llamastack- with the value of the flag or the current conda environment. Change this to be either the value of the flag OR the current image_type. So now the default image names are things like: `llamastack-venv` `llamastack-conda` `llamastack-container` Signed-off-by: Charlie Doern <[email protected]>
leseb
approved these changes
Feb 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
since
--image-namehas a default of None, often a user can getllamastack-Nonewhen using environments like venv and container.currently, the image_name is llamastack- with the value of the flag or the current conda environment. Change this to be either the value of the flag OR the current image_type. So now the default image names are things like:
llamastack-venvllamastack-condallamastack-containerCloses #1131
Test Plan
tested locally and checked created environments