fix: resolve type hint issues and import dependencies #1176
+14
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leseb
requested review from
ashwinb,
yanxi0830,
hardikjshah,
dltn,
raghotham,
dineshyv,
vladimirivic,
sixianyi0721,
ehhuang and
terrytangyuan
as code owners
facebook-github-bot
added
the
CLA Signed
|
|
ashwinb
reviewed
Feb 20, 2025
| from typing import List | ||
| from typing import TYPE_CHECKING, List | ||
|
|
||
| if TYPE_CHECKING: |
ashwinb
requested changes
Feb 20, 2025
| @@ -19,6 +19,8 @@ | |||
| # Import necessary components from Matplotlib | |||
| from matplotlib.backends.backend_agg import FigureCanvasAgg | |||
|
|
|||
| from llama_stack.providers.inline.tool_runtime.code_interpreter.code_env_prefix import _open_connections | |||
There was a problem hiding this comment.
this is actually not correct. the _open_connections method is dynamically made available to the interpreter by bundling code from "code_env_prefix.py" -- by literally prefixing it -- and then "eval"ing it within a sandboxed interpreter.
| @@ -231,7 +231,7 @@ def worker_process_entrypoint( | |||
| while True: | |||
| try: | |||
| task = req_gen.send(result) | |||
| if isinstance(task, str) and task == _END_SENTINEL: | |||
| if isinstance(task, str) and task == EndSentinel(): | |||
There was a problem hiding this comment.
wait what? this was just referencing some unknown symbol?! 🤦
- Fixed type hinting and missing imports across multiple modules. - Improved compatibility by using `TYPE_CHECKING` for conditional imports. - Updated `pyproject.toml` to enforce stricter linting. Signed-off-by: Sébastien Han <[email protected]>
ashwinb
approved these changes
Feb 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
TYPE_CHECKINGfor conditional imports.pyproject.tomlto enforce stricter linting.Signed-off-by: Sébastien Han [email protected]