feat: allow specifying specific tool within toolgroup #1239
+179
−197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
ehhuang
requested review from
ashwinb,
yanxi0830,
hardikjshah,
dltn,
raghotham,
dineshyv,
vladimirivic,
sixianyi0721 and
terrytangyuan
as code owners
ehhuang
commented
Feb 24, 2025
| @@ -803,7 +803,7 @@ | |||
| } | |||
| ], | |||
| "source": [ | |||
| "model_id = \"meta-llama/Llama-3.1-70B-Instruct\"\n", | |||
| "model_id = \"meta-llama/Llama-3.3-70B-Instruct\"\n", | |||
There was a problem hiding this comment.
Upgraded to 3.3 as it worked by default. 3.1 might require some prompt tuning to get it to call knowledge_search tool.
Summary: Test Plan: Summary: Test Plan:
ehhuang
force-pushed
the
pr1238
branch
5 times, most recently
from
c186226 to
52141b1
Compare
Summary: E.g. `builtin::rag::knowledge_search` Test Plan: LLAMA_STACK_CONFIG=fireworks pytest -s -v tests/client-sdk/agents/ --safety-shield meta-llama/Llama-Guard-3-8B
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
E.g.
builtin::rag::knowledge_searchTest Plan:
LLAMA_STACK_CONFIG=fireworks pytest -s -v tests/client-sdk/agents/ --safety-shield meta-llama/Llama-Guard-3-8B
Stack created with Sapling. Best reviewed with ReviewStack.