Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docker compose improvements #3202

Merged
merged 3 commits into from
Oct 10, 2024
Merged

docker compose improvements #3202

merged 3 commits into from
Oct 10, 2024

Conversation

haarg
Copy link
Member

@haarg haarg commented Oct 10, 2024

Fixes and improves a few things for docker compose:

  • Specify a shorter COLUMNS value to try to prevent wrapping when used with docker compose in the foreground.
  • Add a watch option to rebuild the image when the cpanfile is updated.
  • Add a dependency on web-asset-build to web-server. This means if you specifically run the web-service, you'll still properly get the assets built.

haarg added 3 commits October 10, 2024 15:04
@haarg
docker compose: add rebuild on cpanfile update
3384835
@haarg
docker compose: shorter default columns
23fbcce 
When running docker compose in foreground mode, all output lines are
prefixed by a label for the container. Since we are using a default
columns value of 120, under compose we should default to a shorter value
to accomodate for the label.
@haarg
docker compose: web-service depends on web-asset-build
3bf892e
@haarg haarg merged commit ffbab6c into master Oct 10, 2024
11 checks passed
@haarg haarg deleted the haarg/docker-compose-improvements branch October 10, 2024 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oalders oalders oalders approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@haarg @oalders