use temp directory for xslate cache #3216
Merged
+10
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were already deleting the xslate cache directory on startup, because it was having problems with refreshing the templates properly. And in a deployment, we don't have any permanent storage anyway. So we can just use a temp directory for the cache. Since we aren't caching templates anymore, we no longer need the var directory.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3216 +/- ##
==========================================
- Coverage 73.17% 73.10% -0.08%
==========================================
Files 69 69
Lines 2397 2398 +1
Branches 338 338
==========================================
- Hits 1754 1753 -1
- Misses 516 517 +1
- Partials 127 128 +1
|
oalders
approved these changes
Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were already deleting the xslate cache directory on startup, because it was having problems with refreshing the templates properly. And in a deployment, we don't have any permanent storage anyway. So we can just use a temp directory for the cache.
Since we aren't caching templates anymore, we no longer need the var directory.
Fixes #3215