Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Namespace selection in the dialog #323

Merged
merged 12 commits into from
Jan 29, 2025
Merged

Namespace selection in the dialog #323

merged 12 commits into from
Jan 29, 2025

Conversation

Razz4780
Copy link
Contributor

@Razz4780 Razz4780 commented Jan 29, 2025 •
edited
Loading

Screencast.from.2025-01-29.13-29-33.webm

Pain

@Razz4780 Razz4780 requested a review from meowjesty January 29, 2025 12:52
meowjesty
meowjesty approved these changes Jan 29, 2025
View reviewed changes
Copy link
Member

@meowjesty meowjesty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some stuff that can be cleared with comments, so approving to end the suffering.

modules/core/src/main/kotlin/com/metalbear/mirrord/MirrordApi.kt Show resolved Hide resolved
modules/core/src/main/kotlin/com/metalbear/mirrord/MirrordExecDialog.kt Show resolved Hide resolved
modules/core/src/main/kotlin/com/metalbear/mirrord/MirrordExecDialog.kt Show resolved Hide resolved
modules/core/src/main/kotlin/com/metalbear/mirrord/MirrordExecDialog.kt Show resolved Hide resolved
@Razz4780 Razz4780 added this pull request to the merge queue Jan 29, 2025
Merged via the queue into metalbear-co:main with commit c417508 Jan 29, 2025
5 checks passed
@Razz4780 Razz4780 deleted the michals/mbe-619-intellij-namespace-ux branch January 29, 2025 15:11
@aviramha aviramha mentioned this pull request Jan 29, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@meowjesty meowjesty meowjesty approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Razz4780 @meowjesty