Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Michał Smolarek <[email protected]>
  • Loading branch information
DmitryDodzin and Razz4780 authored Jan 30, 2025
1 parent 4d37543 commit a5f9773
Showing 1 changed file with 6 additions and 6 deletions.
12 changes: 6 additions & 6 deletions mirrord/operator/src/crd/policy.rs
Original file line number Diff line number Diff line change
Expand Up @@ -165,22 +165,22 @@ pub struct NetworkPolicy {
pub incoming: IncomingNetworkPolicy,
}

/// Incoming network operations policy that partialy mimics the mirrord network.incoming config.
/// Incoming network operations policy that partialy mimics the mirrord `network.incoming` config.
#[derive(Clone, Default, Debug, Deserialize, Eq, PartialEq, Serialize, JsonSchema)]
#[serde(rename_all = "camelCase")]
pub struct IncomingNetworkPolicy {
#[serde(default)]
pub http_filter: HttpFilterPolicy,
}

/// Http filter policy that allows to specify any filter requirments that users must specify in
/// their config for a successful network steal
/// Http filter policy that allows to specify requirements for the HTTP filter used in a session.
#[derive(Clone, Default, Debug, Deserialize, Eq, PartialEq, Serialize, JsonSchema)]
#[serde(rename_all = "camelCase")]

Check warning on line 178 in mirrord/operator/src/crd/policy.rs

View workflow job for this annotation

GitHub Actions / lint

Diff in /home/runner/work/mirrord/mirrord/mirrord/operator/src/crd/policy.rs
pub struct HttpFilterPolicy {
/// Require user's filter to match this regex if filter is provided. (this works in tandom with
/// `steal-without-filter` block to require the user to specify a header filter for network
/// steal feature)
/// Require the user's header filter to match this regex if such filter is provided.
///
/// This works in tandem with the `steal-without-filter` block
/// to require that the user to specifies a header filter for the network steal feature.
pub header_filter: Option<String>,
}

Expand Down

0 comments on commit a5f9773

Please sign in to comment.