don't report error on notimplemented, might fix go crash (#3045)

metalbear-co · Jan 28, 2025 · e86da43 · e86da43
1 parent b2ac7a1
commit e86da43
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 0 deletions.
diff --git a/changelog.d/3044.fixed.md b/changelog.d/3044.fixed.md
@@ -0,0 +1 @@
+don't report error on notimplemented, might fix go crash
diff --git a/mirrord/layer/src/error.rs b/mirrord/layer/src/error.rs
@@ -221,6 +221,10 @@ impl From<HookError> for i64 {
             HookError::SocketUnsuportedIpv6 => {
                 info!("{fail}")
             }
+            HookError::ResponseError(ResponseError::NotImplemented) => {
+                // this means we bypass, so we can just return to avoid setting libc.
+                return -1;
+            }
             HookError::ProxyError(ref err) => {
                 graceful_exit!(
                     r"Proxy error, connectivity issue or a bug.
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1 @@
		don't report error on notimplemented, might fix go crash