Druid authentication/authorization on router's side

extensions-core/druid-basic-security/src/main/java/io/druid/security/basic/BasicAuthClassCompositionConfig.java

@@ -24,8 +24,8 @@
 
 /**
  * Basic authentication storage/cache/resource handler config.
- * The config is an option to specify classes of user/role managers, caches and notifiers.
- * If a config field is specified then the corresponding class is instantiated
+ * BasicAuthClassCompositionConfig provides options to specify authenticator/authorizer classes.
+ * If a field in this class is non-null then the corresponding class is instantiated
  * regardless of what type of Druid component runs it (see {@link BasicSecurityDruidModule}).
  * Hence every Druid component might be a user/role manager and notify others by sending notifications.
  * Every field must be a valid class name (appropriate for the corresponding goal) or null.

extensions-core/druid-basic-security/src/main/java/io/druid/security/basic/BasicSecurityDruidModule.java

@@ -219,7 +219,7 @@ public List<? extends Module> getJacksonModules()
   public static <T> T getInstance(
       Injector injector,
       String configClassName,
-      Class<? extends T> isCoordClass,
+      Class<? extends T> classRunByCoordinator,
       Class<? extends T> defaultClass
   ) throws ClassNotFoundException
   {
@@ -229,8 +229,8 @@ public static <T> T getInstance(
       final T instance = (T) injector.getInstance(Class.forName(configClassName));
       return instance;
     }
-    if (isCoordClass != null && isCoordinator(injector)) {
-      return injector.getInstance(isCoordClass);
+    if (classRunByCoordinator != null && isCoordinator(injector)) {
+      return injector.getInstance(classRunByCoordinator);
     }
     if (defaultClass != null) {
       return injector.getInstance(defaultClass);

extensions-core/druid-basic-security/src/main/java/io/druid/security/basic/authentication/db/cache/NoopBasicAuthenticatorCacheNotifier.java

@@ -21,6 +21,7 @@
 
 /**
  * Noop basic authenticator cache notifier.
+ * No notification is sent on user udpate.
  * Might be used as a config option to override default authenticator cache notifier.
  */
 public class NoopBasicAuthenticatorCacheNotifier implements BasicAuthenticatorCacheNotifier

extensions-core/druid-basic-security/src/main/java/io/druid/security/basic/authorization/db/cache/NoopBasicAuthorizerCacheNotifier.java

@@ -21,6 +21,7 @@
 
 /**
  * Noop basic authorizer cache notifier.
+ * No notification is sent on user/role udpate.
  * Might be used as a config option to override default authorizer cache notifier.
  */
 public class NoopBasicAuthorizerCacheNotifier implements BasicAuthorizerCacheNotifier