MTG-1110 Add request timeout for PG DB query #371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
andrii-kl
commented
Jan 16, 2025
andrii-kl
commented
- Added configurable timeout for the PG database queries
- Added environment variables to configure PG database timeouts
andrii-kl
requested review from
StanChe,
kstepanovdev,
n00m4d and
armyhaylenko
StanChe
reviewed
Jan 16, 2025
StanChe
approved these changes
Jan 16, 2025
armyhaylenko
approved these changes
Jan 17, 2025
Comment on lines
+151
to
+158
| .map_err(|e| { | ||
| if e.to_string().contains("statement timeout") { | ||
| StorageError::QueryTimedOut | ||
| } else { | ||
| StorageError::Common(e.to_string()) | ||
| } | ||
| })?; | ||
|
|
There was a problem hiding this comment.
would be cool if we could statically type the error in IndexDbError, but if it's not possible then i'm ok with what written here and below
n00m4d
approved these changes
Jan 17, 2025
- Added configurable timeout for the PG database queries - Added environment variables to configure PG database timeouts
- change error code for Query Timed Out error
- simpl optimisations
- update CHANGELOG.md
andrii-kl
force-pushed
the
feature/MTG-1110_add-request-time-out-for-pg-db-query
branch
from
8231c84 to
752fc40
Compare
andrii-kl
deleted the
feature/MTG-1110_add-request-time-out-for-pg-db-query
branch
|
currently we have |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.