[MTG-1258] an option to turn off the json re-download, enabled by default #384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kstepanovdev
approved these changes
Jan 24, 2025
StanChe
force-pushed
the
feature/MTG-1258-turn-off-re-download
branch
from
3687393 to
44de970
Compare
andrii-kl
reviewed
Jan 24, 2025
| @@ -27,12 +27,13 @@ use crate::api::dapi::rpc_asset_convertors::parse_files; | |||
| pub const JSON_BATCH: usize = 300; | |||
| pub const WIPE_PERIOD_SEC: u64 = 60; | |||
| pub const SLEEP_TIME: u64 = 1; | |||
| pub const CLIENT_TIMEOUT: u64 = 5; | |||
| pub const CLIENT_TIMEOUT: Duration = Duration::from_secs(30); | |||
There was a problem hiding this comment.
maybe it makes sense to make this variable configurable throw the env?
andrii-kl
reviewed
Jan 24, 2025
| @@ -267,7 +269,8 @@ pub async fn get_by_ids< | |||
| let json_downloader = json_downloader.clone(); | |||
There was a problem hiding this comment.
What if instead of skipping the update we just make the whole update process as an asynchronous process in the background.
There was a problem hiding this comment.
That'll be a bigger story with the refresh queue. This one is a rather hot fix to deploy today and make live on Monday
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a short-term solution for longer requests we disable the cache invalidation alongside the request.
Also we separate the inline json download timeout from the main workers timeout, letting workers wait for 30 seconds for the response, while the inline download is restricted to 3 seconds.