MTG 1289 Fix redis_total_accounts_parsed metric #398
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This PR fixes counting redis_total_accounts_parsed metric. The issue is that value is incremented by
result.len()
but ifself.message_parser.parse_account(item.data, false)
returns empty vector we don't write anything to theresult
vec, but message was processed by fact. Parse_account method may return empty vector if it received account with program owner which we don't support. So as a result of this issue we can see not very informative metric on Grafana -Unparsed Transactions & Accounts
, which looks like ingester cannot parse all the data, but it's wrong, we see it only because values in metric were not calculated correctly. It didn't happen before because previous Solana snapshot ETL was using Geyser plugin which has accounts filter inside and it sent only accounts which Aura supports. But with PR metaplex-foundation/digital-asset-validator-plugin#88 now ETL sends all the accounts from the snapshot.