Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(api): reorder cursor and options params in api requests #411

Merged
merged 1 commit into from
Feb 12, 2025

Conversation

armyhaylenko
Copy link
Contributor

Reorder cursor and options positioning in RPC request types to align with other das-api implementations in case the user passes RPC params as array.

Copy link
Collaborator

@StanChe StanChe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we have a test please

@armyhaylenko armyhaylenko force-pushed the feat/MTG-1312-reorder-cursor-displayoptions branch from f833018 to 865ffb7 Compare February 10, 2025 17:03
@armyhaylenko armyhaylenko requested a review from StanChe February 10, 2025 17:04
Copy link
Collaborator

@StanChe StanChe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, once CI is green we should merge

@armyhaylenko armyhaylenko force-pushed the feat/MTG-1312-reorder-cursor-displayoptions branch from 865ffb7 to 3f79e5e Compare February 11, 2025 08:47
@armyhaylenko armyhaylenko force-pushed the feat/MTG-1312-reorder-cursor-displayoptions branch from 3f79e5e to 61eba57 Compare February 12, 2025 09:10
Reorder `cursor` and `options` positioning in RPC request types
to align with other das-api implementations in case the user
passes RPC params as array.
@armyhaylenko armyhaylenko force-pushed the feat/MTG-1312-reorder-cursor-displayoptions branch from 61eba57 to 1e8ec2e Compare February 12, 2025 15:27
@armyhaylenko armyhaylenko merged commit cf54be2 into develop Feb 12, 2025
10 checks passed
@armyhaylenko armyhaylenko deleted the feat/MTG-1312-reorder-cursor-displayoptions branch February 12, 2025 16:08
andrii-kl pushed a commit to andrii-kl/aura that referenced this pull request Feb 13, 2025
…plex-foundation#411)

Reorder `cursor` and `options` positioning in RPC request types
to align with other das-api implementations in case the user
passes RPC params as array.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants