Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix cartesian_to_spherical for rank > 2 tensors and real_to_complex transformation #371

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

Fix cartesian_to_spherical for rank > 2 tensors and real_to_complex transformation #371

wants to merge 11 commits into from

Conversation

ppegolo
Copy link

@ppegolo ppegolo commented Jan 21, 2025 •
edited
Loading

@ppegolo
Copy link
Author

ppegolo commented Jan 21, 2025

We'll have to make some changes for properly dispatching operations

@Luthaf
Copy link
Member

Luthaf commented Jan 21, 2025

Thanks for doing this! Do you have a test, some function that proves that the new behavior is correct? Ideally something like in #353

@ppegolo
Copy link
Author

ppegolo commented Jan 21, 2025

Just locally in a notebook, we will add some tests soon

@jwa7 jwa7 changed the title Start fixing CG utils Fix cartesian_to_spherical for rank > 2 tensors and real_to_complex transformation Jan 22, 2025
@jwa7 jwa7 requested a review from Luthaf January 22, 2025 17:38
@jwa7 jwa7 marked this pull request as ready for review January 22, 2025 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Luthaf Luthaf Awaiting requested review from Luthaf

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Errors in Clebsch-Gordan utils
3 participants
@ppegolo @Luthaf @jwa7