Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow easier serialization of stations #36

Merged
merged 3 commits into from
Jun 17, 2024
Merged

Conversation

heikoklein
Copy link
Member

@heikoklein heikoklein commented Jun 8, 2024

This PR allows easier serialization of this class by adding the init_kwargs() method.
It adds also metadata to the str representation of objects of this class.

It adds also tests for Stations.

It also improves the api-documentation, both the Reader are moved to the public API, and the init docs are now moved to the visible class-constructor docs.

@heikoklein heikoklein added this to the m2024-07 milestone Jun 8, 2024
Copy link
Member

@jgriesfeller jgriesfeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all good.

You might want to bump the version though.

@heikoklein
Copy link
Member Author

I do releases/versions outside of PRs. The main=dev branch is unstable by default. I'll make a new release today.

@heikoklein heikoklein merged commit 022c689 into main Jun 17, 2024
1 check passed
@heikoklein heikoklein deleted the station_serialization branch June 17, 2024 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants