-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement relative altitude filter #42
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The specification was a bit unclear. We want to exclude stations which are to far off the gridded topography. To far off is absolute, e.g. 500m independed of topography being at 0m or at 2000m.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks very good. Please make dependencies optional (even if the break the altitude-filter if not installed).
Please use some time on performance-tuning.
The case for stations outside the grid is not documented/tested.
d58f22a
to
f79683c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice. Thanks.
Summary
Implement a relative altitude filter which filters stations based on the relative difference between station altitude and model altitude.
Related Issue
closes #39