48 split reading into init and separate read call

README.md

@@ -43,6 +43,7 @@ with engines['csv_timeseries'].open(
     filename=TEST_FILE,
     filters={'countries': {include=['NO']}}
     ) as ts:
+    ts.read()
     for var in ts.variables():
         # stations
         ts.data(var).stations
@@ -79,6 +80,7 @@ import pyaro.timeseries
 TEST_FILE = "csvReader_testdata.csv"
 engine = pyaro.list_timeseries_engines()["csv_timeseries"]
 ts = engine.open(TEST_FILE, filters=[], fill_country_flag=False)
+ts.read()
 print(ts.variables())
 # stations
 ts.data('SOx').stations

setup.cfg

@@ -1,6 +1,6 @@
 [metadata]
 name = pyaro
-version = 0.0.13.dev0
+version = 0.0.14.dev0
 author = Heiko Klein, Daniel Heinesen
 author_email = [email protected]
 description = pyaro py-aerocom reader objects

src/pyaro/csvreader/CSVTimeseriesReader.py

@@ -86,15 +86,24 @@ def __init__(
         self._set_filters(filters)
         self._extra_metadata = tuple(set(columns.keys()) - set(self.col_keys()))
         if country_lookup:
-            lookupISO2 = _lookup_function()
+            self._lookupISO2 = _lookup_function()
         else:
-            lookupISO2 = None
+            self._lookupISO2 = None
+        self._filename = filename
+        self._columns = columns
+        self._variable_units = variable_units
+        self._csvreader_kwargs = csvreader_kwargs
+
+    def read(self):
+        """read method"""
+
         for path in self._file_iterator:
-            logger.debug("%s: %s", filename, path)
+            logger.debug("%s: %s", self._filename, path)
             self._read_single_file(
-                path, columns, variable_units, lookupISO2, csvreader_kwargs
+                path, self._columns, self._variable_units, self._lookupISO2, self._csvreader_kwargs
             )
 
+
     def _read_single_file(
         self, filename, columns, variable_units, country_lookup, csvreader_kwargs
     ):
@@ -208,3 +217,6 @@ def description(self):
 
     def url(self):
         return "https://github.com/metno/pyaro"
+
+    def read(self):
+        return self.reader_class().read(*args, **kwargs)

src/pyaro/timeseries/Engine.py

@@ -14,6 +14,16 @@ def open(self, filename_or_obj_or_url, *, filters=None):
         """
         pass
 
+    @abc.abstractmethod
+    def read(self):
+        """read-method of the timeseries
+
+        :return pyaro.timeseries.Reader
+        :raises UnknownFilterException
+        """
+        # yield self
+        pass
+
     @property
     @abc.abstractmethod
     def args(self) -> list[str]:

src/pyaro/timeseries/Reader.py

@@ -1,14 +1,14 @@
 import abc
+
 from .Data import Data
 from .Station import Station
-from .Filter import Filter, filters
 
 
 class Reader(abc.ABC):
     """Baseclass for timeseries. This can be used with a context manager"""
 
     @abc.abstractmethod
-    def __init__(self, filename_or_obj_or_url, *, filters=None):
+    def __init__(self, filename_or_obj_or_url, filters=None, **kwargs):
         """Initialize the reader.
 
         This function is usually called from the Engine's open function.
@@ -19,6 +19,18 @@ def __init__(self, filename_or_obj_or_url, *, filters=None):
         """
         pass
 
+    @abc.abstractmethod
+    def read(self):
+        """define read method. All needed parameters should be put into self
+        by the __init__ method
+
+        This function is usually called after the Engine's open function.
+        Should implement context manager
+        """
+        # yield self
+        pass
+
+    @abc.abstractmethod
     def metadata(self) -> dict[str, str]:
         """Metadata set by the datasource.
 

src/pyaro/timeseries/Wrappers.py

@@ -1,10 +1,9 @@
 from .Reader import Reader
-from .Data import Data
 
 
 class VariableNameChangingReader(Reader):
     """A pyaro.timeseries.Reader wrapper taking a real Reader implementation and
-    changing variable names in the original reader. Exampel:
+    changing variable names in the original reader. Example:
 
         with VariableNameChangingReader(pyaro.open_timeseries(file, filters=[]),
                                         {'SOx': 'oxidised_sulphur'}) as ts:
@@ -14,7 +13,7 @@ class VariableNameChangingReader(Reader):
 
     """
 
-    def __init__(self, reader: Reader, reader_to_new: dict[str, str]):
+    def __init__(self, reader: Reader, reader_to_new: dict[str, str], **kwargs, ):
         """Initialize the variable name changes of Reader
 
         :param reader: The Reader instance to change variable names on
@@ -45,6 +44,15 @@ def data(self, varname):
         data._set_variable(varname)
         return data
 
+    def metadata(self):
+        """Get the metadata from the reader
+        NOT changing the variable name to the newly given ones for the moment
+
+        :return: metadata from the original reader class
+        """
+        metadata = self._reader.metadata()
+        return metadata
+
     def stations(self):
         return self._reader.stations()
 
@@ -57,3 +65,11 @@ def variables(self):
 
     def close(self):
         self._reader.close()
+
+    def read(self, ):
+        """define read method. All needed parameters should be put into self
+        by the __init__ method
+
+        This method is called after the Engine's open function.
+        """
+        return self._reader.read()