Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

snappy window ignores minutes in release start time #152

Merged
merged 7 commits into from
Jan 28, 2025
Merged

snappy window ignores minutes in release start time #152

merged 7 commits into from
Jan 28, 2025

Conversation

heikoklein
Copy link
Member

  • fixing minutes when snapPy startTime has minute offset for both NPP and Bomb releases
  • fix seg-faults in bomb-runs with merged output where dry/wet/decay was still using runtime output-positions rather than merged output-positions

fixes #140

@heikoklein heikoklein requested a review from magnusuMET January 26, 2025 17:11
@heikoklein heikoklein linked an issue Jan 26, 2025 that may be closed by this pull request
SnapPy window ignores minutes in release start time #140
Closed
@heikoklein heikoklein merged commit 02c0476 into master Jan 28, 2025
2 checks passed
@heikoklein heikoklein deleted the 140-snappy-window-ignores-minutes-in-release-start-time branch January 28, 2025 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@magnusuMET magnusuMET magnusuMET approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SnapPy window ignores minutes in release start time
2 participants
@heikoklein @magnusuMET