feat: Implement shapeless 2x2 and 3x3 crafting recipes #314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Recipes are loaded from the default datapack on startup. They are transformed into a serialized format, which is also easy to do for a crafting grid inside the player inventory or crafting table GUI, and hence allows for fast comparison of the crafting grid against all recipes. Quite a lot of recipes are now possible to craft, such as planks from logs or dying wool or beds, but many other recipes are shaped and as such not possible yet. Startup time also increases substantially due to the increase in data that must be read and loaded, and should be optimized as future work.
meyfa
added a commit
that referenced
this pull request
Feb 1, 2025
Follow-up to #314. This patch implements parsing of recipe files with the type "minecraft:crafting_shaped", including very complex recipes such as the barrel (no, really - due to there being 12 types of wood in the game, there are 12^8 = 429,981,696 ways to craft a barrel!), along with the required checks when crafting grid slots are changed. This means we now support 932 out of 978 crafting recipes, with the remaining ones needing specialized implementations, such as keeping NBT data when coloring shulker boxes or repairing tools by combining them. In any case, it's now possible to go from logs to planks to a crafting table, and also towards sticks and then torches or even a cobblestone pickaxe.
meyfa
added a commit
that referenced
this pull request
Feb 2, 2025
Follow-up to #314. This patch implements parsing of recipe files with the type "minecraft:crafting_shaped", including very complex recipes such as the barrel (no, really - due to there being 12 types of wood in the game, there are 12^8 = 429,981,696 ways to craft a barrel!), along with the required checks when crafting grid slots are changed. This means we now support 932 out of 978 crafting recipes, with the remaining ones needing specialized implementations, such as keeping NBT data when coloring shulker boxes or repairing tools by combining them. In any case, it's now possible to go from logs to planks to a crafting table, and also towards sticks and then torches or even a cobblestone pickaxe.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recipes are loaded from the default datapack on startup. They are transformed into a serialized format, which is also easy to do for a crafting grid inside the player inventory or crafting table GUI, and hence allows for fast comparison of the crafting grid against all recipes.
Quite a lot of recipes are now possible to craft, such as planks from logs or dying wool or beds, but many other recipes are shaped and as such not possible yet. Startup time also increases substantially due to the increase in data that must be read and loaded, and should be optimized as future work.