encoding: ensure big-endian via COMP #345
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... and use constants for size-lengths as where possible, implementing meyfa#267
|
encode.cob was moved in #343. Could you rebase, please?
By how many percent? |
|
10% more user cpu time with non optimized os packaged GC 3.1.2 on dockerized (x86_64) Ubuntu
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... and use constants for size-lengths as where possible, implementing #267
note: at least on the gitpod docker instance the performance with GC 3.1.2 did actually decrease by percent (but I don't have a clue why, and don't have anything else but valgrind to check for details there) - so please test before pulling.