Prevent empty-block on range over channel #818
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An empty loop over channels is a common pattern:
https://sourcegraph.com/search?q=context%3Aglobal+lang%3AGo+for%5C+range%5C+.*%5C+%5C%7B%5Cs*%5C%7D&patternType=regexp&sm=1&groupBy=repo
https://sourcegraph.com/search?q=context%3Aglobal+lang%3AGo+for%5C+range%5C+.*%5C+%5C%7B%5Cs*%5C%7D+repo%3Agithub.com%2Fgolang%2Fgo&patternType=regexp&sm=1&groupBy=repo
Since the given AST doesn't really provide much type info I had to resort to finding the declaration/definition of the object to figure out whether
for range
was actually looping over a channel.This doesn't feel very reliable, but it works for the test data. I'll be happy to extend the checks if an issue gets reported.
I tried re-adding
file.Pkg.TypeCheck()
from #415, but didn't notice any difference in the AST.Closes #386