misc fixes

mglisse · Aug 3, 2024 · 2485582 · 2485582
1 parent 6ac1c9f
commit 2485582
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 2 deletions.
diff --git a/src/python/gudhi/_ripser.cc b/src/python/gudhi/_ripser.cc
@@ -74,7 +74,11 @@ py::list doit(DistanceMatrix&& dist, int max_dimension, typename DistanceMatrix:
   std::vector<std::vector<std::array<T, 2>>> dgms;
   {
     py::gil_scoped_release release;
-    auto output = [&](T birth, T death){ dgms.back().push_back({birth, death}); };
+    auto output = [&](T birth, T death){
+      // Skip empty intervals
+      if (birth < death)
+        dgms.back().push_back({birth, death});
+    };
     auto switch_dim = [&](int new_dim){
       dgms.emplace_back();
     };

diff --git a/src/python/gudhi/sklearn/rips_persistence.py b/src/python/gudhi/sklearn/rips_persistence.py
@@ -135,7 +135,8 @@ def __transform(self, inp):
         else:
             raise ValueError("Only 'point cloud', 'lower distance matrix', 'full distance matrix' and 'coo_matrix' are valid input_type") # move to __init__?
 
-        return [dgm[dim] for dim in self.dim_list_]
+        # dgm stops at n-2
+        return [dgm[dim] if dim < len(dgm) else np.empty((0,2)) for dim in self.dim_list_]
 
     def transform(self, X, Y=None):
         """Compute all the Vietoris-Rips complexes and their associated persistence diagrams.