Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

encapsulating pathname in batticks to escape spaces in pathnames #43

Merged
merged 2 commits into from
Mar 19, 2024
Merged

encapsulating pathname in batticks to escape spaces in pathnames #43

merged 2 commits into from
Mar 19, 2024

Conversation

akhiljns
Copy link
Collaborator

fixes #42

db/db.go Outdated Show resolved Hide resolved
…s before actual use to avoid escaped chars in homedirname
@mhewedy
Copy link
Owner

mhewedy commented Mar 19, 2024

LGTM, thanks.

I have a question... on which OSes you did the test?

@mhewedy mhewedy merged commit f69afb0 into mhewedy:master Mar 19, 2024
2 checks passed
@mhewedy
Copy link
Owner

mhewedy commented Mar 19, 2024

Included in the new Release https://github.com/mhewedy/vermin/releases/tag/v0.128.0

@akhiljns
Copy link
Collaborator Author

LGTM, thanks.

I have a question... on which OSes you did the test?

Ahh good question!
tested this on windows, let me test this on my mac as well, however I have the silicon chipset so virtualbox will be difficult to run since virtualbox is only supported on intel Macs as of now

i'm going to dual boot my PC with linux this weekend let me see, i'll also test this on a linux

@mhewedy
Copy link
Owner

mhewedy commented Mar 20, 2024 via email

@akhiljns
Copy link
Collaborator Author

Thanks for getting back to me

On Wed, 20 Mar 2024 at 11:43 AM Akhil @.> wrote: LGTM, thanks. I have a question... on which OSes you did the test? Ahh good question! tested this on windows, let me test this on my mac as well, however I have the silicon chipset so virtualbox will be difficult to run since virtualbox is only supported on intel Macs as of now i'm going to dual boot my PC with linux this weekend let me see, i'll also test this on a linux — Reply to this email directly, view it on GitHub <#43 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAIJEYJAQGKGIO6NMYSQ6K3YZFDZPAVCNFSM6AAAAABE2HQPQCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMBZGA2DENBZGI . You are receiving this because you modified the open/close state.Message ID: @.>

hey so i checked this on mac, and this is failing, I will be raising another PR today to fix it on all OS

@mhewedy
Copy link
Owner

mhewedy commented Mar 20, 2024

@akhiljns

can you share the exception?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Not able to perform VBoxManage.exe import
2 participants