-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
encapsulating pathname in batticks to escape spaces in pathnames #43
Conversation
…s before actual use to avoid escaped chars in homedirname
LGTM, thanks. I have a question... on which OSes you did the test? |
Included in the new Release https://github.com/mhewedy/vermin/releases/tag/v0.128.0 |
Ahh good question! i'm going to dual boot my PC with linux this weekend let me see, i'll also test this on a linux |
Thanks for getting back to me
…On Wed, 20 Mar 2024 at 11:43 AM Akhil ***@***.***> wrote:
LGTM, thanks.
I have a question... on which OSes you did the test?
Ahh good question!
tested this on windows, let me test this on my mac as well, however I have
the silicon chipset so virtualbox will be difficult to run since virtualbox
is only supported on intel Macs as of now
i'm going to dual boot my PC with linux this weekend let me see, i'll also
test this on a linux
—
Reply to this email directly, view it on GitHub
<#43 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAIJEYJAQGKGIO6NMYSQ6K3YZFDZPAVCNFSM6AAAAABE2HQPQCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMBZGA2DENBZGI>
.
You are receiving this because you modified the open/close state.Message
ID: ***@***.***>
|
hey so i checked this on mac, and this is failing, I will be raising another PR today to fix it on all OS |
can you share the exception? |
fixes #42