Skip to content

Commit

Permalink
bpo-44838: Refine the custom syntax errors for invalid 'if' expressio…
Browse files Browse the repository at this point in the history
  • Loading branch information
pablogsal authored Aug 5, 2021
1 parent 3d315c3 commit f5cbea6
Show file tree
Hide file tree
Showing 4 changed files with 621 additions and 554 deletions.
2 changes: 1 addition & 1 deletion Grammar/python.gram
Original file line number Diff line number Diff line change
Expand Up @@ -1083,7 +1083,7 @@ invalid_expression:
# Soft keywords need to also be ignored because they can be parsed as NAME NAME
| !(NAME STRING | SOFT_KEYWORD) a=disjunction b=expression_without_invalid {
RAISE_SYNTAX_ERROR_KNOWN_RANGE(a, b, "invalid syntax. Perhaps you forgot a comma?") }
| a=disjunction 'if' b=disjunction !'else' { RAISE_SYNTAX_ERROR_KNOWN_RANGE(a, b, "expected 'else' after 'if' expression") }
| a=disjunction 'if' b=disjunction !('else'|':') { RAISE_SYNTAX_ERROR_KNOWN_RANGE(a, b, "expected 'else' after 'if' expression") }

invalid_named_expression:
| a=expression ':=' expression {
Expand Down
8 changes: 8 additions & 0 deletions Lib/test/test_syntax.py
Original file line number Diff line number Diff line change
Expand Up @@ -152,6 +152,14 @@
Traceback (most recent call last):
SyntaxError: expected 'else' after 'if' expression
>>> if True:
... print("Hello"
...
... if 2:
... print(123))
Traceback (most recent call last):
SyntaxError: invalid syntax
>>> True = True = 3
Traceback (most recent call last):
SyntaxError: cannot assign to True
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
Fixed a bug that was causing the parser to raise an incorrect custom
:exc:`SyntaxError` for invalid 'if' expressions. Patch by Pablo Galindo.
Loading

0 comments on commit f5cbea6

Please sign in to comment.