Currency class and proxy configurations #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Michael.
First let me thank you for your work. Awesome gem. I'm always using it on one or two consoles just to output some alerts and to test some components on my job (Yet another monitoring platform :) ).
I've added a Currency class, following your implementation style with the Historical class. I had implemented the functionality inside the Yahoo class but the currency symbol's (for instance EURUSD) don't apply to the rest of the function list.
I've also added the possibility to configure a proxy. Usually I'm behind one.
My next step is to DRY the (re)connection methods to clean up the code in the main classes (Yahoo, Google, Historical and Currency).
I was thinking to use the Excon gem to replace the Net::HTTP connections, since Excon it's much more faster. The problem is that the Proxy configuration for Excon seems to be failing in some rvm/ruby 1.9.* configurations and for me that's a big problem. Nevertheless i can do that it you agree.
Thanks again for your work and I hope you like my humble contribution.