New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changing messages comments/descriptions affects protocol version #70

Open

Roman- opened this issue May 3, 2023 · 1 comment

Assignees

Labels

Collaborator

Roman- commented May 3, 2023

Here is what protocol version calculator should take into account:

Msgs IDs and names
Order of msgs fields and their types
Fields names (e.g. changing single field name from "uint32 capacity_liters" to "uint32 capacity_ml" must change the hash)

Fields comments and message descriptions must not affect protocol version

Roman- added the enhancement label

Roman- self-assigned this

Roman- mentioned this issue

Robust version hash generator #77

Merged

Roman- closed this as completed in

Collaborator Author

Roman- commented Dec 11, 2023

Reverted pull request as it did not consider swapping two consecutive data with same size

Roman- reopened this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment