Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Robust version hash generator #77

Merged
merged 1 commit into from
Dec 11, 2023
Merged

Robust version hash generator #77

merged 1 commit into from
Dec 11, 2023

Conversation

Roman-
Copy link
Collaborator

@Roman- Roman- commented Dec 8, 2023

Prior to generating version hash from the module dict, the VersionProtocol now sorts the module, discards comments and names, and only then computes the md5 hash.

Fix for #70

@Roman- Roman- added the enhancement New feature or request label Dec 8, 2023
@Roman- Roman- requested review from DrTon and Zemledelec December 8, 2023 18:43
@Roman- Roman- merged commit 4553266 into master Dec 11, 2023
2 checks passed
@Roman- Roman- deleted the fix_version_hash_calc branch April 17, 2024 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant