Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JS messgen parser fails silently with improperly ordered complex message IDs #68

Merged
merged 3 commits into from
Apr 3, 2023
Merged

JS messgen parser fails silently with improperly ordered complex message IDs #68

merged 3 commits into from
Apr 3, 2023

Conversation

meded90
Copy link
Collaborator

@meded90 meded90 commented Mar 31, 2023 •
edited
Loading

bug #67

@meded90 meded90 changed the title JS messgen parser fails silently with improperly ordered complex message IDs #67 JS messgen parser fails silently with improperly ordered complex message IDs Mar 31, 2023
Zemledelec
Zemledelec requested changes Apr 3, 2023
View reviewed changes
Copy link
Collaborator

@Zemledelec Zemledelec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"m" is not and id, it's name. And now it doesnt's work.

port/js/src/messgen.js Outdated Show resolved Hide resolved
@Zemledelec Zemledelec merged commit 5c80061 into microavia:master Apr 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zemledelec Zemledelec Zemledelec approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@meded90 @Zemledelec @meded7