Guide @ServerFilter @FilterMethod guide #1408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdelamo
changed the title
timyates
approved these changes
Jan 5, 2024
guides/micronaut-server-filter-request/java/src/test/java/example/micronaut/MemoryAppender.java
Outdated
Show resolved
Hide resolved
timyates
approved these changes
Jan 5, 2024
graemerocher
reviewed
Jan 5, 2024
| if (LOG.isTraceEnabled()) { | ||
| HttpHeaders headers = request.getHeaders() | ||
| for (String headerName : headers.names()) { | ||
| if (headerName.equalsIgnoreCase(HttpHeaders.AUTHORIZATION)) { |
There was a problem hiding this comment.
not sure we should be encouraging unsafe patterns like this, how do you know what other headers might contain sensitive values?
There was a problem hiding this comment.
Would you prefer if I remove the part where we skip logging the Authorization header and instead log every HTTP header in the guide?
I think showing users to be careful about what they log is better than logging everything.
Please note that in core, we skip logging some headers. Of course, what header is sensitive is application specific.
There was a problem hiding this comment.
perhaps you could use HeaderUtils since it already does some masking
There was a problem hiding this comment.
graemerocher
approved these changes
Jan 15, 2024
AndreaLaGrotteria
pushed a commit
to AndreaLaGrotteria/micronaut-guides
that referenced
this pull request
Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.