micronaut-oracle-autonomous-db fixes #1411
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
without this change, Maven apps failed because http-client was in test scope
sdelamo
approved these changes
Jan 9, 2024
AndreaLaGrotteria
pushed a commit
to AndreaLaGrotteria/micronaut-guides
that referenced
this pull request
Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An Oracle employee contacted me about issues with the guide. One was the missing
@Serdeableannotation on the domain class, and the other was due to thehttp-clientdependency being in test scope. I fixed those and did more updates.The testing section of the guide was also broken because the test referenced the
Oracleclass but it wasn't included in the guide, only the zips. I ended up removing testresources since the users will be creating an autonomous database, so it makes sense to just use that for the tests.I disabled running the tests because they now need an existing autonomous database, and they weren't doing much good anyway since they didn't catch the
@Serdeablebug or the Maven/http-clientbug.