Http client configuration for kubernetes openapi client #839
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@graemerocher @yawkat - I closed the previous and created a new PR for kubernetes http client configuration. We can't use
ServiceHttpClientConfiguration
for kubernetes client since it doesn't have@BootstrapContextCompatible
annotation, so I created a new http client config class:KubernetesHttpClientConfiguration
. The new class uses the following managed beans if those were created, otherwise creates new ones:So all those config settings will be the same as for other http clients. So only properties from
HttpClientConfiguration
class can be customized for kubernetes http client comparing to other http clients since we need to set request timeouts for streaming on the following way:Does this seem ok to you?