-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DekorateSpec fails #1854
base: 4.0.x
Are you sure you want to change the base?
DekorateSpec fails #1854
Conversation
This reverts commit 800532a.
Ok, so This is no longer true... I will add it as a version here |
Ok, so the old version we used to use (1.0.3) had issues with versions, so the generated YAML was infact invalid and contained stuff like
So I bumped it up to 3.6.1 (the latest) However they dropped If you agree, I suggest we:
|
@alvarosanchez ☝️ I know you've been working with Kubernetes, does this seem sensible? Do you use dekorate in any of your demos? |
Here's a demo of Dekorate v3 with Micronaut 3.9: https://github.com/alvarosanchez/micronaut-kubernetes-demo Note that Dekorate has been removed from Platform because it really belongs to Micronaut Kubernetes. There is an open PR which is currently blocked by a pending new release. |
We will wait for micronaut-projects/micronaut-kubernetes#580 to fix this up here |
@alvarosanchez any update? |
I noticed that 3.7.0 has the missing artifact, so I've created micronaut-projects/micronaut-kubernetes#598 |
Now blocked by dekorateio/dekorate#1231 🤦 |
No description provided.