Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Final tidyup #637

Merged
merged 2 commits into from
Jul 4, 2024
Merged

Final tidyup #637

merged 2 commits into from
Jul 4, 2024

Conversation

Emily-Jiang
Copy link
Member

Specify the dependency on MP Telemetry instead of directly on OTel APIs

tck/pom.xml Show resolved Hide resolved
@benjamin-confino
Copy link
Contributor

I ran this locally and this change caused no issues, approving.

@Emily-Jiang Emily-Jiang merged commit 998e631 into microprofile:main Jul 4, 2024
1 of 4 checks passed
@rhusar
Copy link
Contributor

rhusar commented Jul 4, 2024

I ran this locally and this change caused no issues, approving.

Sounds like you have microprofile-telemetry-api:pom:2.0 installed manually? Becuase it's not publicly available on central yet. Are we waiting for this to be synced?

[ERROR] Failed to execute goal on project microprofile-fault-tolerance-tck: Could not resolve dependencies for project org.eclipse.microprofile.fault-tolerance:microprofile-fault-tolerance-tck:jar:4.2-SNAPSHOT
[ERROR] dependency: org.eclipse.microprofile.telemetry:microprofile-telemetry-api:pom:2.0 (provided)

@Azquelt
Copy link
Member

Azquelt commented Jul 5, 2024

@rhusar Yes, that's correct. microprofile-telemetry-api:2.0 has been staged in preparation for release. You can either build it locally from the 2.0 tag, or temporarily add the staging repository to the pom (https://oss.sonatype.org/content/repositories/staging/).

Be aware that if you take either of these options, you'll want to manually remove the staged artifacts from your local maven repository in case they change as maven may not re-download them if it thinks you already have them locally.

The safer option for testing changes locally at the moment is to temporarily change the dependency on telemetry back to the RC version available on maven central.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants