Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor common props and delete empty props #1528

Merged
merged 4 commits into from
Jan 6, 2020
Merged

refactor common props and delete empty props #1528

merged 4 commits into from
Jan 6, 2020

Conversation

TimothyMothra
Copy link
Member

@TimothyMothra TimothyMothra commented Jan 4, 2020 •
edited
Loading

Fix Issue #1214
Fix Issue #1527

Changes

  • Move Common.props to the common props in PropsRoot.
  • Note that half our products were shipping with FULL symbols, and the other half were shipping with PDBONLY. I've changed all projects to use FULL, until we have time to investigate if we can switch to the newer PORTABLE.

Notes for reviewers:

  • We support comment build triggers
    • /AzurePipelines run will queue all builds
    • /AzurePipelines run <pipeline-name> will queue a specific build

reyang
reyang approved these changes Jan 6, 2020
View reviewed changes
Copy link
Member

@reyang reyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once Get-DoesPdbExist got fixed.

@TimothyMothra TimothyMothra merged commit 5f1457d into develop Jan 6, 2020
@TimothyMothra TimothyMothra deleted the tilee/refactor_common_props branch January 6, 2020 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reyang reyang reyang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TimothyMothra @reyang