Add Windows image field to Admin VM template

[jonnyry]

Add OS image field to Admin VM template in alignment with Guacamole VMs, to allow for easier OS image customisation.

[github-actions]

Unit Test Results

0 tests   0 ✅  0s ⏱️
0 suites  0 💤
0 files    0 ❌

Results for commit af9be44.

♻️ This comment has been updated with latest results.

[jonnyry]

/test 9a798fa

[github-actions]

🤖 pr-bot 🤖

🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/12815913528 (with refid 5470df0d)

(in response to this comment from @jonnyry)

[jonnyry]

/test 9a798fa

[github-actions]

🤖 pr-bot 🤖

🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/12819486131 (with refid 5470df0d)

(in response to this comment from @jonnyry)

[tamirkamara]

Is this really needed @jonnyry ?

[jonnyry]

Is this really needed @jonnyry ?

It is useful for us to align our Windows images to a single base image. However if there's not value to the wider user base I'm happy to close.

(I realise that we could just override the image details directly in the terraform, however this aligns the mechanism with that used in the Guacamole VMs and makes it simpler to maintain.)

[ShakutaiGit]

LGTM
(very small/nit comments)

[jonnyry]

@marrobi @ShakutaiGit thanks for your reviews.

I've made a small change to bring across the secure_boot_enabled and vtpm_enabled image config options that were added to main since this PR was originally submitted.

It ensures these values are configed per image, and not hardcoded to true as they were prior. (The image you select may not be secure boot capable.)

[jonnyry]

/test

[github-actions]

🤖 pr-bot 🤖

🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/13310479033 (with refid 5470df0d)

(in response to this comment from @jonnyry)

[marrobi]

@jonnyry not sure this will be covered by any of the tests?