Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Defender: Azure Cosmos DB should disable public network access #4324

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Defender: Azure Cosmos DB should disable public network access #4324

wants to merge 5 commits into from
+14 −11

Conversation

jonnyry
Copy link
Collaborator

@jonnyry jonnyry commented Feb 5, 2025

Resolves #4322

  • Changes Public network access on the two cosmos accounts from Selected networks to Disabled, unless local debugging is enabled
  • Also updates the Cosmos middleware IPs - they've changed since they were orignally added (see this article)

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 5, 2025 •
edited
Loading

Unit Test Results

0 tests   0 ✅  0s ⏱️
0 suites  0 💤
0 files    0 ❌

Results for commit b9f4260.

♻️ This comment has been updated with latest results.

marrobi
marrobi approved these changes Feb 5, 2025
View reviewed changes
Copy link
Member

@marrobi marrobi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jonnyry jonnyry requested a review from tamirkamara February 6, 2025 10:09
@jonnyry
Copy link
Collaborator Author

jonnyry commented Feb 9, 2025

/test

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 9, 2025

🤖 pr-bot 🤖

🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/13227249471 (with refid d5333ffb)

(in response to this comment from @jonnyry)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marrobi marrobi marrobi approved these changes

@tamirkamara tamirkamara Awaiting requested review from tamirkamara

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Defender: Azure Cosmos DB should disable public network access
2 participants
@jonnyry @marrobi