Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix firewall rules creation on upgrade for Guacamole #4343

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

marrobi
Copy link
Member

@marrobi marrobi commented Feb 7, 2025

Fixes #3814

Add firewall rule creation to the upgrade step in Guacamole template schema.

  • Add a step to the upgrade section in templates/workspace_services/guacamole/template_schema.json to add network firewall rules for Guacamole.
  • Ensure the new step in the upgrade section matches the step in the install section.

For more details, open the Copilot Workspace session.

Fixes #3814

Add firewall rule creation to the upgrade step in Guacamole template schema.

* Add a step to the `upgrade` section in `templates/workspace_services/guacamole/template_schema.json` to add network firewall rules for Guacamole.
* Ensure the new step in the `upgrade` section matches the step in the `install` section.

---

For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/microsoft/AzureTRE/issues/3814?shareId=XXXX-XXXX-XXXX-XXXX).
Copy link

github-actions bot commented Feb 7, 2025

Unit Test Results

0 tests   0 ✅  0s ⏱️
0 suites  0 💤
0 files    0 ❌

Results for commit 80de1a6.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

If Guacamole fails on install, upgrade does not recreate firewall rules.
1 participant