definition-parser: include package name in error #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Piotr Błażejewicz (Peter Blazejewicz) <[email protected]> This proposed change is intended to allow developers quickly figure out the real reason of `getTypingInfo` failing due to version mismatch. Current error message and related stack trace does not contain a clue about the package failing and with the context of DT repository and local development artifacts, this removes the problem with definition parser failing on the stale data from local repository (non tracked folders, etc). Thanks!
|
Port of microsoft/types-publisher#788 |
andrewbranch
approved these changes
Jun 10, 2020
|
cool! Thanks! |
sandersn
pushed a commit
that referenced
this pull request
Nov 29, 2021
Fix error reporting for `--noLint`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Co-authored-by: Piotr Błażejewicz (Peter Blazejewicz) [email protected]
This proposed change is intended to allow developers quickly figure out
the real reason of
getTypingInfofailing due to version mismatch.Current error message and related stack trace does not contain a clue
about the package failing and with the context of DT repository and
local development artifacts, this removes the problem with definition
parser failing on the stale data from local repository (non tracked
folders, etc).
Thanks!