check test 2

microsoft · Jan 3, 2025 · 904995f · 904995f
1 parent d88c5c0
commit 904995f
Showing 1 changed file with 6 additions and 6 deletions.
diff --git a/tests/span_tests.cpp b/tests/span_tests.cpp
@@ -258,17 +258,17 @@ TEST(span_test, from_pointer_pointer_construction)
     }
 
     // this will fail the std::distance() precondition, which asserts on MSVC debug builds
-    {
+    { // this test succeeds on all platforms, but it relies on UB
         auto workaround_macro = [&]() { span<int> s{&arr[1], &arr[0]}; };
         EXPECT_DEATH(workaround_macro(), expected);
     }
 
     // this will fail the std::distance() precondition, which asserts on MSVC debug builds
-    //{
-    //    int* p = nullptr;
-    //    auto workaround_macro = [&]() { span<int> s{&arr[0], p}; };
-    //    EXPECT_DEATH(workaround_macro(), expected);
-    //}
+    {
+        int* p = nullptr;
+        auto workaround_macro = [&]() { span<int> s{&arr[0], p}; };
+        EXPECT_DEATH(workaround_macro(), expected);
+    }
 
     {
         int* p = nullptr;